Skip to content

fix: use version.py for versioning - #804

Merged
sasha-gitg merged 1 commit into
googleapis:mainfrom
sasha-gitg:fix_versioning
Oct 29, 2021
Merged

sasha-gitg merged 1 commit into
googleapis:mainfrom
sasha-gitg:fix_versioning

Conversation

@sasha-gitg

Copy link
Copy Markdown
Member

@sasha-gitg
sasha-gitg requested review from a team, busunkim96 and dizcology October 29, 2021 16:33
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2021
@product-auto-label product-auto-label Bot added the api: aiplatform Issues related to the AI Platform API. label Oct 29, 2021

@busunkim96 busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - https://github.com/googleapis/python-api-core/blob/main/setup.py uses this setup and this looks similar.

@sasha-gitg
sasha-gitg requested a review from ji-yaqi October 29, 2021 17:19
@sasha-gitg
sasha-gitg merged commit 514031f into googleapis:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants