Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.
This repository was archived by the owner on May 7, 2026. It is now read-only.

query.fetch() fails if GOOGLE_CLOUD_DISABLE_GRPC is set #124

Closed
#136
Closed
query.fetch() fails if GOOGLE_CLOUD_DISABLE_GRPC is set#124
#136
Assignees
HemangChothani
Labels
api: datastoreIssues related to the googleapis/python-datastore API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@tomthorogood
tomthorogood
opened on Nov 30, 2020

This new behavior causes an error: run_query() got an unexpected keyword argument 'request' because when the GOOGLE_CLOUD_DISABLE_GRPC environment variable is set (which is a requirement in some runtimes, e.g., when using gunicorn with gevent), the underlying HTTPDatastoreAPI#run_query method does not accept a request parameter.

Example:

# run_query.py

from google.cloud import datastore

client = datastore.Client()  # Assuming an auth'd environment
results = [entity for entity in client.query(kind="Foo").fetch()]

I feel like this can be fixed by updating the signature for the HTTPDatastoreAPI#run_query to accept request and only subsequently build the request object if it's not passed in, so that the signatures match for all implementations.

Activity

  1. product-auto-label
    added
    api: datastoreIssues related to the googleapis/python-datastore API.
    on Nov 30, 2020
  2. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Dec 1, 2020
  3. HemangChothani
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Dec 8, 2020
  4. HemangChothani
    self-assigned this
    on Dec 8, 2020

  5. tseaver commented on Dec 9, 2020

    @tseaver
    tseaver
    on Dec 9, 2020
    Contributor

    @tomthorogood Thanks for the report!

    @crwilcox We need to set up CI (maybe periodic, rather than precommit?) to exercise the library with GOOGLE_CLOUD_DISABLE_GRPC set.

  6. crwilcox commented on Dec 9, 2020

    @crwilcox
    crwilcox
    on Dec 9, 2020
    Contributor

    #133

  7. tseaver commented on Dec 9, 2020

    @tseaver
    tseaver
    on Dec 9, 2020
    Contributor

    Note that we have a broader issue here: all of the methods of the HTTPDatastoreAPI need to be updated to match the request-only pattern of the new GRPC API.

  8. tseaver commented on Dec 9, 2020

    @tseaver
    tseaver
    on Dec 9, 2020
    Contributor

    The HTTPDatastoreAPI is also missing reserve_ids. :(

  9. tseaver
    added 7 commits that reference this issue on Dec 9, 2020

    fix: update 'HTTPDatastoreAPI.allocate_ids' to follow request-only pa…

    02be9c6

    fix: update 'HTTPDatastoreAPI.rollback' to follow request-only pattern

    45e54f8

    fix: update 'HTTPDatastoreAPI.commit' to follow request-only pattern

    74ed7fb

    fix: update 'HTTPDatastoreAPI.begin_transaction' to follow request-on…

    685ec12

    fix: update 'HTTPDatastoreAPI.run_query' to follow request-only pattern

    60e384f

    fix: update 'HTTPDatastoreAPI.lookup' to follow request-only pattern

    7b0a44b

    fix: add 'retry' / 'timeout' args to HTTPDatastoreAPI methods

    136dd2f
  10. crwilcox
    closed this as completedin #136on Dec 9, 2020
  11. crwilcox
    added a commit that references this issue on Dec 9, 2020

    fix: make HTTPDatastoreAPI compatible w/ microgen Gapic API (#136)

    d522799

  12. tomthorogood commented on Feb 12, 2021

    @tomthorogood
    tomthorogood
    on Feb 12, 2021
    Author

    I am so sorry, I only just saw that this was resolved. Thank you so much! I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: datastoreIssues related to the googleapis/python-datastore API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions