Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: adds bounds checking because pandas now handles microsecond reso… - #166

Merged
chalmerlowe merged 2 commits into
mainfrom
out-of-bounds-validation
Jan 3, 2023
Merged

chalmerlowe merged 2 commits into
mainfrom
out-of-bounds-validation

Conversation

@chalmerlowe

Copy link
Copy Markdown
Contributor

Fixes #160
Fixes #159
Fixes #158
Fixes #157

🦕

@chalmerlowe
chalmerlowe requested review from a team and tswast December 21, 2022 13:27
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Dec 21, 2022

@shollyman shollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, assuming the coverage issue is straightforward to resolve. If you need a followup review let me know.

Comment thread db_dtypes/__init__.py Outdated
@chalmerlowe
chalmerlowe merged commit 357a315 into main Jan 3, 2023
@chalmerlowe
chalmerlowe deleted the out-of-bounds-validation branch January 3, 2023 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: s Pull request size is small.

Projects

None yet

3 participants