Repository navigation
[ggj] feat(drift): Generate gapic_metadata.json, add integ test framework support - #657
Conversation
google-cla
Bot
added
the
cla: yes
commented
Feb 17, 2021
|
@vchudnov-g PTAL at the generated |
| serviceClientProtoBuilder.putRpcs(rpcName, methodList); | ||
| } | ||
|
|
||
| metadataBuilder = |
There was a problem hiding this comment.
I'm curious: I see you use the pattern fooBuilder = fooBuilder.doSomething().setSomething(). Is the assignment redundant? I thought the builder methods were mutating, rather than functional methods returning a new copy of the object with the changes requested.
There was a problem hiding this comment.
No, the original builder doesn't mutate - AFAIK AutoValue classes are all immutable.
There was a problem hiding this comment.
Oh, weird. In the monolith, builders were used as though their setters mutate. My mental model had been that AutoValue classes are immutable but AutoValue.Builder clases were mutable; I'll need to figure this out. Is there more than one AutoValue impl around?
2 participants
No description provided.