Repository navigation
chore: make exception for non-cloud artifacts - #1787
Conversation
| if main_artifact_group_id != "com.google.cloud" and \ | ||
| main_artifact_group_id != "com.google.area120" and \ | ||
| main_artifact_group_id != "com.google.analytics": | ||
| prefix = main_artifact_group_id |
There was a problem hiding this comment.
Python 3.9 doesn't have a switch statement.
There was a problem hiding this comment.
Can you use "in" operator with a list of the 3 elements?
There was a problem hiding this comment.
Also add source code comment for the reason why this logic is needed.
=> nevermind. you added comment above.
suztomo
left a comment
suztomo
left a comment
There was a problem hiding this comment.
@JoeWang1127 Update the title with "chore:" and ensure you merge with "chore:" to main. This line may appear in the pull request in downstream repositories and without "chore:" it would appear in their release note of irrelevant repositories.
|
Also "bugfix" is not a suffix in conventional commits https://www.conventionalcommits.org/en/v1.0.0/#specification |
JoeWang1127
changed the title
|
@suztomo changed the PR title. |
3 participants
Fix googleapis/google-cloud-java#9304