Skip to content

ci: automatic kokoro label in and /gcbrun comment - #1965

Merged
suztomo merged 2 commits into
masterfrom
suztomo-patch-2
Jun 5, 2024
Merged

suztomo merged 2 commits into
masterfrom
suztomo-patch-2

Conversation

@suztomo

@suztomo suztomo commented May 15, 2024

Copy link
Copy Markdown
Member

From reading the configuration (https://github.com/googleapis/repo-automation-bots/pull/1682/files), it accepts multiple objects.

@blakeli0

Copy link
Copy Markdown
Contributor

Do we expect this change to be propagated to all libraries through Owlbot PRs?

@suztomo

suztomo commented May 15, 2024

Copy link
Copy Markdown
Member Author

Do we expect this change to be propagated to all libraries through Owlbot PRs?

Yes.

@blakeli0

Copy link
Copy Markdown
Contributor

Do we expect this change to be propagated to all libraries through Owlbot PRs?

Yes.

Thanks! I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

@suztomo

suztomo commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

There's no OwlBot configuration for google-cloud-java any more https://github.com/googleapis/google-cloud-java/tree/main/.github. Thus the postprocessor does not run.

@suztomo
suztomo enabled auto-merge (squash) June 3, 2024 14:47
@suztomo

suztomo commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

Experiment succeeded in googleapis/java-bigtable#2233 (comment)

@blakeli0

blakeli0 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

There's no OwlBot configuration for google-cloud-java any more https://github.com/googleapis/google-cloud-java/tree/main/.github. Thus the postprocessor does not run.

We only recently removed the OwlBot configuration, but this file was introduced years ago, so this file should at least exist in google-cloud-java. Just like in java-bigtable, this file exists but a few new configs are added by this change.

@suztomo

suztomo commented Jun 5, 2024

Copy link
Copy Markdown
Member Author

The file was not there before the monorepo migraiton https://github.com/googleapis/google-cloud-java/tree/main_202208/.github.

so this file should at least exist in google-cloud-java

What observations made you think that?

@suztomo

suztomo commented Jun 5, 2024

Copy link
Copy Markdown
Member Author

The postprocessor had been running, but owlbot-java has special treatment not to process the root directory of google-cloud-java.

@blakeli0 blakeli0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @diegomarquezp We need to add these templates to hermetic build as well.

@suztomo
suztomo merged commit bd2bae8 into master Jun 5, 2024
@suztomo
suztomo deleted the suztomo-patch-2 branch June 5, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants