Repository navigation
fix: samples tests should pass if no samples exist - #803
Merged
Merged
Conversation
daniel-sanche
requested review from
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
October 13, 2020 23:11
google-cla
Bot
added
the
cla: yes
daniel-sanche
changed the title
SurferJeffAtGoogle
approved these changes
Oct 14, 2020
SurferJeffAtGoogle
left a comment
SurferJeffAtGoogle
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please wait for @busunkim96's approval.
busunkim96
approved these changes
Oct 14, 2020
busunkim96
left a comment
busunkim96
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this @daniel-sanche!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
test-samples.shruns into a bug and crashes if the./samplesdirectory doesn't exist in a repo. I'd argue that the check should pass automatically if there are no samples to test against.This would fix the issue we're running into on python-logging, where no CI tests will pass until we merge the PR adding samples
If we'd prefer having no samples to count as a test failure, I'd suggest we least add a better error message. Right now the code just crashes by trying to cd into a directory that doesn't exist