octavia: http_version monitor field must have float type #3355

Activity

1. pierreprinetti commented on Apr 28, 2025

   

   pierreprinetti

   on Apr 28, 2025

   Member

   More actions

   Why would http_version be a numeric type? There is no guarantee that version strings, including HTTP's, will always be parseable as decimal numbers.
2. kayrus commented on Apr 28, 2025

   

   kayrus

   on Apr 28, 2025

   Last edited by kayrus

   ContributorAuthor

   More actions

   it has a float type in API ref. And in order to keep backward compatibility and transparency, I made internal conversion of the type, and users can still use string type in SDK. I also added acceptance tests and they seem to work ok in all openstack versions. The only thing is that all lbaas acceptance tests against master branch are failing, this is not related to the fix. I guess something is broken in octavia master.

   UPD: see also #2282 (comment)
3. mandre

   closed this as completedin #3356on Apr 30, 2025