Repository navigation
Manila: add extend and shrink share functionality - #1175
Conversation
|
Build failed.
|
jtopjian
left a comment
jtopjian
left a comment
There was a problem hiding this comment.
@gman0 Overall looks good - just a few minor changes.
I'm not able to run the acceptance tests at this time. To confirm: you've tested this implementation?
The Builder methods have the following pattern:
To-Resource-Action-Result
I noticed a few other methods aren't following this pattern - no big deal, they can be updated at some point - but let's fix these ones.
Let me know if you have any questions.
| // ExtendOptsBuilder allows extensions to add additional parameters to the | ||
| // Extend request. | ||
| type ExtendOptsBuilder interface { | ||
| ToExtendMap() (map[string]interface{}, error) |
| ToExtendMap() (map[string]interface{}, error) | ||
| } | ||
|
|
||
| // ExtendOpts contains the options for creation of a Extend request. |
There was a problem hiding this comment.
How about:
ExtendOpts contains options for extending a Share.
| // ShrinkOptsBuilder allows extensions to add additional parameters to the | ||
| // Shrink request. | ||
| type ShrinkOptsBuilder interface { | ||
| ToShrinkMap() (map[string]interface{}, error) |
| ToShrinkMap() (map[string]interface{}, error) | ||
| } | ||
|
|
||
| // ShrinkOpts contains the options for creation of a Shrink request. |
There was a problem hiding this comment.
How about:
ShrinkOpts contains options for shrinking a Share
…ons; fixed comments
|
@jtopjian Thanks for the review! PTAL
Yes, I've tested both extend and shrink operations in our on-site OpenStack cloud. |
|
Build failed.
|
|
Thanks! |
3 participants
For #1174
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
Extend:
extend: https://github.com/openstack/manila/blob/master/manila/api/v2/shares.py#L385extendimplementation: https://github.com/openstack/manila/blob/master/manila/share/api.py#L1765Shrink:
shrink: https://github.com/openstack/manila/blob/master/manila/api/v2/shares.py#L397shrinkimplementation: https://github.com/openstack/manila/blob/master/manila/share/api.py#L1823/cc @jtopjian
Ready for review