Skip to content

Baremetal V1 API: Node management - #1450

Merged
jtopjian merged 3 commits into
gophercloud:masterfrom
stbenjam:node-mgt
Feb 16, 2019
Merged

jtopjian merged 3 commits into
gophercloud:masterfrom
stbenjam:node-mgt

Conversation

@stbenjam

Copy link
Copy Markdown
Contributor

For #1429

This covers node management for boot devices, validation, and injecting non-masking interrupts.

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

@theopenlab-ci

theopenlab-ci Bot commented Feb 13, 2019

Copy link
Copy Markdown

Build succeeded.

@coveralls

coveralls commented Feb 13, 2019 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 76.388% when pulling e8e89ee on stbenjam:node-mgt into 9e57e2f on gophercloud:master.

@stbenjam

Copy link
Copy Markdown
Contributor Author

This is ready as well.

@jtopjian jtopjian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stbenjam I've left two comments for review. Please let me know if you have any questions.

Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
Comment thread openstack/baremetal/v1/nodes/results.go Outdated
@stbenjam

Copy link
Copy Markdown
Contributor Author

Thanks, addressed comments in 79e15b2

@theopenlab-ci

theopenlab-ci Bot commented Feb 15, 2019

Copy link
Copy Markdown

Build succeeded.

@theopenlab-ci

theopenlab-ci Bot commented Feb 15, 2019

Copy link
Copy Markdown

Build failed.

@jtopjian jtopjian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@jtopjian
jtopjian merged commit dcc6e84 into gophercloud:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants