Repository navigation
Baremetal API v1: Node provision state - #1452
Merged
Merged
Conversation
stbenjam
commented
Feb 15, 2019
stbenjam
commented
Feb 15, 2019
39 of 61 tasks
|
Build failed.
|
jtopjian
reviewed
Feb 16, 2019
jtopjian
left a comment
jtopjian
left a comment
Contributor
There was a problem hiding this comment.
@stbenjam This is still WIP, but I wanted to comment on the configdrive part sooner than later. I also caught a few minor name and comment nits.
Also, Travis seems to be complaining about a gofmt issue: https://travis-ci.org/gophercloud/gophercloud/jobs/493974066#L1346
dtantsur
reviewed
Feb 25, 2019
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
stbenjam
force-pushed
the
provision-states
branch
3 times, most recently
from
February 25, 2019 14:47
259f676 to
bc6c791
Compare
stbenjam
commented
Feb 25, 2019
stbenjam
force-pushed
the
provision-states
branch
from
February 25, 2019 14:49
bc6c791 to
a50a849
Compare
stbenjam
force-pushed
the
provision-states
branch
from
February 25, 2019 14:52
c51fc3b to
72484d1
Compare
stbenjam
changed the title
Contributor
Author
|
Should be good for another review |
|
Build failed.
|
jtopjian
requested changes
Feb 26, 2019
|
Build succeeded.
|
jtopjian
approved these changes
Feb 26, 2019
jtopjian
left a comment
jtopjian
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thank you for your work and discussion on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1429
This implements the code to adjust provisioning state.
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: