Repository navigation
Baremetal API v1: Node Power State - #1479
Merged
Merged
Conversation
39 of 61 tasks
|
Build succeeded.
|
Contributor
Author
|
This should be ready for a review |
jtopjian
requested changes
Feb 26, 2019
Contributor
Author
|
Thanks, updated! |
|
Build succeeded.
|
jtopjian
reviewed
Feb 27, 2019
| // PowerStateOpts for a request to change a node's power state. | ||
| type PowerStateOpts struct { | ||
| Target TargetPowerState `json:"target" required:"true"` | ||
| Timeout int `json:"timeout,omitempty"` |
Contributor
There was a problem hiding this comment.
One more question: will there ever be a need to specify a timeout of 0? If so, then this will need to be changed to *int.
Contributor
Author
There was a problem hiding this comment.
Ah good question - it cannot be 0, so I think this is good to go!
https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L505-L506
jtopjian
approved these changes
Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1429
API's for changing a Node's power state.
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: