Repository navigation
Baremetal API V1: Allocations - #1528
Merged
Merged
Conversation
39 of 61 tasks
|
Build failed.
|
stbenjam
marked this pull request as ready for review
March 27, 2019 18:38
stbenjam
changed the title
Contributor
Author
|
This should be ready for a review, thanks. |
Contributor
Author
|
@dtantsur FYI |
|
Build failed.
|
dtantsur
approved these changes
Mar 28, 2019
dtantsur
left a comment
dtantsur
left a comment
Contributor
There was a problem hiding this comment.
Looks correct to me, thanks!
jtopjian
requested changes
Mar 29, 2019
stbenjam
force-pushed
the
allocations
branch
2 times, most recently
from
March 29, 2019 15:40
073ad0c to
e9fe23c
Compare
|
Build succeeded.
|
Contributor
Author
|
@jtopjian Updated, should be good to go |
jtopjian
approved these changes
Mar 30, 2019
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Ironic Allocations.
For #1429
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: