Skip to content

Baremetal API V1: Support set RAID config - #1559

Merged
jtopjian merged 1 commit into
gophercloud:masterfrom
stbenjam:RAID
May 4, 2019
Merged

jtopjian merged 1 commit into
gophercloud:masterfrom
stbenjam:RAID

Conversation

@stbenjam

@stbenjam stbenjam commented May 1, 2019

Copy link
Copy Markdown
Contributor

For #1429

This adds support to set a node's RAID configuration.

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

Docs

Code

@stbenjam stbenjam mentioned this pull request May 1, 2019
39 of 61 tasks
@coveralls

coveralls commented May 1, 2019 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 76.598% when pulling e84f3e4 on stbenjam:RAID into e0311c0 on gophercloud:master.

@theopenlab-ci

theopenlab-ci Bot commented May 1, 2019

Copy link
Copy Markdown

Build succeeded.

@jtopjian jtopjian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stbenjam I'm not sure if this was ready for review, but I did a first pass and left some comments. Please let me know if you have any questions.

Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
@stbenjam
stbenjam force-pushed the RAID branch 3 times, most recently from 25c8338 to 645c068 Compare May 2, 2019 18:03
@stbenjam

stbenjam commented May 2, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for the review, I've addressed your comments. Ready for another look.

@theopenlab-ci

theopenlab-ci Bot commented May 2, 2019

Copy link
Copy Markdown

Build succeeded.

@jtopjian jtopjian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stbenjam Thanks!

Just one horribly small nit. I hate to block merging for it, but it's probably one of those things that will be forgotten if not done now.

Comment thread openstack/baremetal/v1/nodes/requests.go Outdated
@jtopjian

jtopjian commented May 3, 2019

Copy link
Copy Markdown
Contributor

@stbenjam Also, Travis is reporting an error with the unit tests:

--- FAIL: TestSetRAIDConfigMaxSize (0.00s)
	convenience.go:300: Expected JSON:
		{
		  "logical_disks": [
		    {
		      "is_root_volume": true,
		      "raid_level": "1",
		      "size_gb": "MAX"
		    }
		  ]
		}
	convenience.go:308: Actual JSON:
		{
		  "logical_disks": [
		    {
		      "is_root_volume": true,
		      "raid_level": "5",
		      "size_gb": "MAX"
		    }
		  ]
		}
	convenience.go:39: Failure in http_responses.go, line 90: The generated JSON structure differed.
FAIL

Might just be a test fixture that needs changed.

@stbenjam

stbenjam commented May 3, 2019

Copy link
Copy Markdown
Contributor Author

Thanks, updated

@theopenlab-ci

theopenlab-ci Bot commented May 3, 2019

Copy link
Copy Markdown

Build failed.

@theopenlab-ci

theopenlab-ci Bot commented May 3, 2019

Copy link
Copy Markdown

Build failed.

@jtopjian jtopjian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian
jtopjian merged commit 6f9faf5 into gophercloud:master May 4, 2019
@stbenjam
stbenjam deleted the RAID branch May 5, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants