Skip to content

Baremetal API: Return versions supported by the API - #1577

Merged
jtopjian merged 1 commit into
gophercloud:masterfrom
stbenjam:api-version
Jun 26, 2019
Merged

jtopjian merged 1 commit into
gophercloud:masterfrom
stbenjam:api-version

Conversation

@stbenjam

Copy link
Copy Markdown
Contributor

@stbenjam

Copy link
Copy Markdown
Contributor Author

@dtantsur If you have a moment, would you mind sanity checking this? I need to understand what the API supports, so I can get rid of the microversioning in the terraform ironic provider.

@theopenlab-ci

theopenlab-ci Bot commented May 21, 2019

Copy link
Copy Markdown

Build failed.

Comment thread openstack/baremetal/apiversions/results.go
Comment thread openstack/baremetal/apiversions/results.go
@jtopjian

Copy link
Copy Markdown
Contributor

@stbenjam Did you need any help finishing this up?

It looks like Travis is reporting a small gofmt error: https://travis-ci.org/gophercloud/gophercloud/jobs/535405881#L1387

@stbenjam

Copy link
Copy Markdown
Contributor Author

@stbenjam Did you need any help finishing this up?

It looks like Travis is reporting a small gofmt error: https://travis-ci.org/gophercloud/gophercloud/jobs/535405881#L1387

Oops, thanks for the reminder. I haven't had a chance to come back to it yet, I'll try to find some time this week.

@stbenjam stbenjam changed the title [WIP] Baremetal API: Return versions supported by the API Baremetal API: Return versions supported by the API Jun 26, 2019
@coveralls

coveralls commented Jun 26, 2019 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 76.859% when pulling a0c15b5 on stbenjam:api-version into 1574321 on gophercloud:master.

@stbenjam

Copy link
Copy Markdown
Contributor Author

This should be good to go

@theopenlab-ci

theopenlab-ci Bot commented Jun 26, 2019

Copy link
Copy Markdown

Build succeeded.

@jtopjian jtopjian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian
jtopjian merged commit c0ec4ee into gophercloud:master Jun 26, 2019
@stbenjam
stbenjam deleted the api-version branch June 26, 2019 20:12
@mandre mandre mentioned this pull request Dec 31, 2024
39 of 61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants