Support http_basic auth_strategy for Ironic - #1983

Coverage increased (+0.02%) to 79.398% when pulling 141aaa8 on iurygregory:ironic-http_basic into 8b8b153 on gophercloud:master.

Build succeeded.

• gophercloud-unittest : SUCCESS in 4m 07s
• gophercloud-acceptance-test : SUCCESS in 1h 38m 19s
• gophercloud-acceptance-test-ironic : SUCCESS in 30m 27s

@iurygregory Thank you for submitting this!

I left one doc nit. The only reason it's important is because these docs get generated to display on godoc.org.

In addition, can you change all occurrences of Http to HTTP? This will help match Gophercloud's coding style. If http is all lowercase to begin with, it can stay http. For example:

Sure!

httpClient := httpbasic.NewBareMetalHTTPBasic()

With regard to the acceptance tests, per our email conversation, you can omit them, but given you've submitted a really good set of tests, a better option might be to add a new conditional here (https://github.com/gophercloud/gophercloud/blob/master/acceptance/clients/conditions.go) so that these tests are only run when a certain environment variable is set.

I noticed that we only run the tests from the v1, according to the shell script.
I will add the changes to conditions.go also, just wondering if anything else is required.

And finally, per our contributor's guide, we need to also reference the service-side code that implements this functionality.

Should be enough add the to add the links for the code changes in ironic in the PR description?
https://review.opendev.org/727467
https://review.opendev.org/729070

Please let me know if you have any questions. Thank you again.

Build failed.

• gophercloud-unittest : SUCCESS in 4m 25s
• gophercloud-acceptance-test : FAILURE in 2h 53m 01s
• gophercloud-acceptance-test-ironic : SUCCESS in 29m 43s

I will add the changes to conditions.go also, just wondering if anything else is required.

You'll need to add the conditional check to the beginning of each test. For example:

Should be enough add the to add the links for the code changes in ironic in the PR description?

That's perfect - thank you!

clients.

I will add the changes to conditions.go also, just wondering if anything else is required.

You'll need to add the conditional check to the beginning of each test. For example:

gophercloud/acceptance/openstack/compute/v2/hypervisors_test.go

Line 17 in 737db56

clients.RequireAdmin(t)

Should be enough add the to add the links for the code changes in ironic in the PR description?

That's perfect - thank you!

Done =) Thanks! (sorry I clicked the wrong button and closed the PR)

Build succeeded.

• gophercloud-unittest : SUCCESS in 5m 33s
• gophercloud-acceptance-test : SUCCESS in 1h 45m 36s
• gophercloud-acceptance-test-ironic : SUCCESS in 27m 52s

Build succeeded.

• gophercloud-unittest : SUCCESS in 4m 00s
• gophercloud-acceptance-test : SUCCESS in 1h 37m 39s
• gophercloud-acceptance-test-ironic : SUCCESS in 1h 36m 57s