Skip to content

Added support for baremetal portgroups - #3290

Merged
EmilienM merged 4 commits into
gophercloud:mainfrom
Sharpz7:baremetal-portgroups
Mar 5, 2025
Merged

EmilienM merged 4 commits into
gophercloud:mainfrom
Sharpz7:baremetal-portgroups

Conversation

@Sharpz7

@Sharpz7 Sharpz7 commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

Fixes #3285

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

Built from https://docs.openstack.org/api-ref/baremetal/#portgroups-portgroups (For Ironic this is considered reliable)

@github-actions github-actions Bot added edit:baremetal This PR updates baremetal code semver:minor Backwards-compatible change labels Feb 4, 2025
@coveralls

coveralls commented Feb 4, 2025 •

Copy link
Copy Markdown

Coverage Status

coverage: 78.74% (+0.01%) from 78.729%
when pulling a475a62 on Sharpz7:baremetal-portgroups
into e7b58a9 on gophercloud:main.

@jayofdoom jayofdoom left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 seems like a faithful implementation of portgroups

@github-actions github-actions Bot added semver:major Breaking change and removed semver:minor Backwards-compatible change labels Feb 5, 2025
@EmilienM
EmilienM merged commit c860416 into gophercloud:main Mar 5, 2025
@mandre mandre mentioned this pull request Dec 31, 2024
39 of 61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

edit:baremetal This PR updates baremetal code semver:major Breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Portgroups from Baremetal API

4 participants