Skip to content

core: add missing Builder interfaces - #3363

Merged
stephenfin merged 1 commit into
gophercloud:mainfrom
kayrus:opts-builder
May 7, 2025
Merged

stephenfin merged 1 commit into
gophercloud:mainfrom
kayrus:opts-builder

Conversation

@kayrus

@kayrus kayrus commented May 2, 2025

Copy link
Copy Markdown
Contributor

This PR adds missing Builder interfaces, allowing additional parameters to be added to requests.

@kayrus kayrus added the backport-v2 This PR will be backported to v2 label May 2, 2025
@github-actions github-actions Bot added edit:networking This PR updates networking code edit:loadbalancer This PR updates loadbalancer code edit:compute This PR updates compute code edit:sharedfilesystems This PR updates sharedfilesystems code edit:blockstorage This PR updates blockstorage code edit:identity This PR updates identity code semver:major Breaking change labels May 2, 2025
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 78.674%. first build
when pulling 1137240 on kayrus:opts-builder
into 0d5dccb on gophercloud:main.

@kayrus

kayrus commented May 2, 2025

Copy link
Copy Markdown
Contributor Author

Despite modifying function signatures, this PR can be backported to v2 since it adds an interface type and compatible with opts.

@kayrus

kayrus commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

@stephenfin @pierreprinetti @mandre @EmilienM kindly ping

@stephenfin
stephenfin merged commit d08ea79 into gophercloud:main May 7, 2025
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown

Labels semver-major and semver-unknown block backports to the stable branch v2.

@kayrus
kayrus deleted the opts-builder branch May 7, 2025 10:10
@kayrus kayrus added backport-v2 This PR will be backported to v2 and removed semver:major Breaking change backport-v2 This PR will be backported to v2 labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:blockstorage This PR updates blockstorage code edit:compute This PR updates compute code edit:identity This PR updates identity code edit:loadbalancer This PR updates loadbalancer code edit:networking This PR updates networking code edit:sharedfilesystems This PR updates sharedfilesystems code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants