Skip to content

[v2] dns: implement shared zones list - #3393

Merged
mandre merged 1 commit into
gophercloud:v2from
kayrus:list-zone-share-v2
Jun 2, 2025
Merged

[v2] dns: implement shared zones list#3393
mandre merged 1 commit into
gophercloud:v2from
kayrus:list-zone-share-v2

Conversation

@kayrus

@kayrus kayrus commented May 22, 2025

Copy link
Copy Markdown
Contributor

This is a manual backport of the #3390

@kayrus
kayrus requested a review from EmilienM May 22, 2025 14:50
@github-actions github-actions Bot added edit:dns This PR updates dns code v2 This PR targets v2 semver:major Breaking change labels May 22, 2025
@coveralls

coveralls commented May 22, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 63.663% (-0.02%) from 63.679%
when pulling 29194cf on kayrus:list-zone-share-v2
into af02ce6 on gophercloud:v2.

@kayrus kayrus mentioned this pull request May 27, 2025
Merged
@kayrus

kayrus commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

@EmilienM @mandre @pierreprinetti @stephenfin kindly ping

stephenfin
stephenfin approved these changes May 28, 2025
View reviewed changes

@stephenfin stephenfin left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflicts are in tests and are due to commit eed41cd being absent, which we probably don't want to backport due to its size.

PS: @kayrus it would be helpful if this information ☝️ was included in the commit message since I assume you had to figure that out yourself to do the backport and it'd save me the effort of figuring it out again. For example, see 2435700. Just my 2c

@stephenfin

stephenfin commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Also, the designate dalmatian failure is expected until they merge https://review.opendev.org/c/openstack/designate/+/950569/3 (and revert https://review.opendev.org/c/openstack/designate/+/949094)

@kayrus

kayrus commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

@stephenfin thanks for the references.
@EmilienM I'll wait for your approval, since you have concerns about the major semver tag.

mandre
mandre approved these changes Jun 2, 2025
View reviewed changes

@mandre mandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandre
mandre merged commit 6b87370 into gophercloud:v2 Jun 2, 2025
@kayrus
kayrus deleted the list-zone-share-v2 branch June 14, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes
@stephenfin stephenfin stephenfin approved these changes
@EmilienM EmilienM Awaiting requested review from EmilienM
@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

No one assigned

Labels

edit:dns This PR updates dns code semver:major Breaking change v2 This PR targets v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kayrus @coveralls @stephenfin @mandre