Skip to content

[v2] Adjust List func to accept a Builder in tenants, routers and security groups packages - #3397

Merged
stephenfin merged 1 commit into
gophercloud:v2from
kayrus:secgroup_listoptsbuilder-v2
May 23, 2025
Merged

stephenfin merged 1 commit into
gophercloud:v2from
kayrus:secgroup_listoptsbuilder-v2

Conversation

@kayrus

@kayrus kayrus commented May 23, 2025

Copy link
Copy Markdown
Contributor

Manual Backport: #3097

This is a follow-up for the #3070

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

[PUT URLS HERE]

@github-actions github-actions Bot added edit:networking This PR updates networking code v2 This PR targets v2 edit:identity This PR updates identity code semver:major Breaking change labels May 23, 2025
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 63.672% (-0.003%) from 63.675%
when pulling cece9a4 on kayrus:secgroup_listoptsbuilder-v2
into 48faa0f on gophercloud:v2.

@kayrus
kayrus requested a review from stephenfin May 23, 2025 15:20

@stephenfin stephenfin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted previously at #3375 (comment), this is flagged as a major API change but isn't actually. Tests are happy. LGTM.

@stephenfin
stephenfin merged commit ac09823 into gophercloud:v2 May 23, 2025
@kayrus
kayrus deleted the secgroup_listoptsbuilder-v2 branch May 23, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

edit:identity This PR updates identity code edit:networking This PR updates networking code semver:major Breaking change v2 This PR targets v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants