Skip to content

identityv3/service: add name and description fields - #3566

Merged
mandre merged 1 commit into
gophercloud:mainfrom
winiciusallan:services-add-fields
Dec 8, 2025
Merged

mandre merged 1 commit into
gophercloud:mainfrom
winiciusallan:services-add-fields

Conversation

@winiciusallan

Copy link
Copy Markdown
Contributor

Fixes #3561

Links to the line numbers/files in the OpenStack source code that support the code in this PR:

https://docs.openstack.org/api-ref/identity/v3/#show-service-details
https://github.com/openstack/keystone/blob/master/keystone/catalog/schema.py#L153

@github-actions github-actions Bot added edit:identity This PR updates identity code semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Nov 26, 2025
@coveralls

coveralls commented Nov 26, 2025 •

Copy link
Copy Markdown

Coverage Status

coverage: 63.807% (-0.03%) from 63.833%
when pulling a2037fa on winiciusallan:services-add-fields
into 40f4edd on gophercloud:main.

Comment thread openstack/identity/v3/services/requests.go Outdated
Comment thread openstack/identity/v3/services/results.go Outdated
Comment thread openstack/identity/v3/services/results.go
Comment thread openstack/identity/v3/services/requests.go Outdated
Comment thread openstack/identity/v3/services/results.go
@winiciusallan
winiciusallan force-pushed the services-add-fields branch 2 times, most recently from e5abcc8 to 2af615d Compare November 28, 2025 19:01
@kayrus

kayrus commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

@stephenfin @mandre could you please take a look into this PR as well?

@mandre mandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar in principle to #3532, except that we've been more careful not breaking backward compatibility here. Good job!

LGTM

Comment thread openstack/identity/v3/services/results.go
@mandre
mandre enabled auto-merge December 8, 2025 07:56
@mandre
mandre added this pull request to the merge queue Dec 8, 2025
Merged via the queue into gophercloud:main with commit 3440f39 Dec 8, 2025
62 checks passed
@winiciusallan
winiciusallan deleted the services-add-fields branch December 8, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:identity This PR updates identity code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

identity.v3.Services is missing fields from Keystone API

4 participants