Repository navigation
Add metric-storage (Aetos) v1 service support - #3638
Conversation
github-actions
Bot
added
edit:openstack
|
Hey Juan, do you think it would be possible to add acceptance tests? I imagine this require a new job for which we enable the service in the relevant openstack releases (master only?). You can find the jobs configuration here. |
github-actions
Bot
added
edit:config
github-actions
Bot
added
semver:minor
|
Sure, ill work on it |
github-actions
Bot
added
edit:actions
|
@mandre Apparently this is waiting on the approval of a maintainer to execute tests. This did not happened in the previous run, I imagine it is related with the new test set I instroduced. |
The project is configured to require a maintainer to approve running tests for first time contributors, that's why :) |
|
coverage: 63.927% (-0.03%) from 63.953% — jlarriba:main into gophercloud:main |
thanks for the approval! I can debug the issues now. |
|
@mandre need approval again, i am afraid |
|
@mandre I dont really know why the epoxy Octavia tests are failing, it seems to be completely unrelated to my patch. What do you think? |
@jlarriba After checking the logs, it appears to be a permission error. This is a known issue; you can check it here. The issue above was regarding the Flamingo release. I don't know what has changed in the Epoxy release that made the tests get red, but one solution looks like changing the udev permissions for the KVM device, as suggested in the issue. edit: Detailing more, looks like the patch to use Ubuntu Noble for amphora was backported to the Epoxy release, and Canonical has implemented several security changes in this new release, especially regarding the use of AppArmor, which restricts unprivileged user namespaces. |
|
@winiciusallan Thank you very much for your input! @mandre Thanks to Winicius' knowledge I created a patch to also force jammy ubuntu version in epoxy tests: #3656 |
|
The error should be fixed by #3660, but I dont know how to re-run the test. |
You'll need to rebase your PR on top of main. I see you pushed a commit but it's empty, so presumably you forgot to run |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
All done, thank you for your advice. |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
From what I can tell, and how little I know about the Aetos service, this looks almost ready to merge.
|
One last thing flagged by zizmor needs fixing (similar to what was done in b3e4310) then it's good to go IMO. You'll want to add to your workflow: |
Aetos is a Keystone-authenticated reverse proxy for Prometheus that enforces multi-tenant RBAC on all Prometheus queries. This adds Go bindings for the Prometheus HTTP API exposed under /api/v1/ with OpenStack authentication. Supported operations: Query, Labels, LabelValues, Series, Targets, RuntimeInfo, CleanTombstones, DeleteSeries, Snapshot.
Sorry about this, this seems to be introduced very recently and I was not aware. Done. |
5 participants
Aetos is a Keystone-authenticated reverse proxy for Prometheus that enforces multi-tenant RBAC on all Prometheus queries. This adds Go bindings for the Prometheus HTTP API exposed under /api/v1/ with OpenStack authentication.
Supported operations: Query, Labels, LabelValues, Series, Targets, RuntimeInfo, CleanTombstones, DeleteSeries, Snapshot.
Fixes #3636
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: