Skip to content

Implement READ operations on Placement traits - #3658

Merged
mandre merged 2 commits into
gophercloud:mainfrom
Etua:add-trait-read-operations
Mar 27, 2026
Merged

mandre merged 2 commits into
gophercloud:mainfrom
Etua:add-trait-read-operations

Conversation

@Etua

@Etua Etua commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added edit:placement This PR updates placement code semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Mar 26, 2026
@coveralls

coveralls commented Mar 26, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 63.889% (+0.03%) from 63.859%
when pulling 058f517 on Etua:add-trait-read-operations
into 8d07d46 on gophercloud:main.

@Etua
Etua force-pushed the add-trait-read-operations branch from 2683fc8 to 7850e65 Compare March 26, 2026 08:48
@Etua

Etua commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

@mandre I think the tests should pass now, they do in my local setup.

mandre
mandre previously approved these changes Mar 27, 2026

@mandre mandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread internal/acceptance/openstack/placement/v1/traits_test.go Outdated
@mandre
mandre enabled auto-merge March 27, 2026 08:19
auto-merge was automatically disabled March 27, 2026 12:11

Head branch was pushed to by a user without write access

@mandre
mandre enabled auto-merge March 27, 2026 12:53
@mandre
mandre added this pull request to the merge queue Mar 27, 2026
Merged via the queue into gophercloud:main with commit 8dfa2dc Mar 27, 2026
125 checks passed
@Etua
Etua deleted the add-trait-read-operations branch March 27, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:placement This PR updates placement code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants