Repository navigation
Implement READ operations on Placement traits - #3658
Merged
Merged
Conversation
Related: gophercloud#526 API reference: https://docs.openstack.org/api-ref/placement/#traits Code reference: https://github.com/openstack/placement/blob/stable/2025.1/placement/handlers/trait.py#L108-L124 https://github.com/openstack/placement/blob/stable/2025.1/placement/handlers/trait.py#L152-L178 Signed-off-by: Dominik Danelski <[email protected]>
Etua
force-pushed
the
add-trait-read-operations
branch
from
March 26, 2026 08:48
2683fc8 to
7850e65
Compare
Contributor
Author
|
@mandre I think the tests should pass now, they do in my local setup. |
mandre
previously approved these changes
Mar 27, 2026
mandre
enabled auto-merge
March 27, 2026 08:19
Signed-off-by: Dominik Danelski <[email protected]>
auto-merge was automatically disabled
March 27, 2026 12:11
Head branch was pushed to by a user without write access
mandre
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #526
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API reference: https://docs.openstack.org/api-ref/placement/#traits
Code reference:
https://github.com/openstack/placement/blob/stable/2025.1/placement/handlers/trait.py#L108-L124
https://github.com/openstack/placement/blob/stable/2025.1/placement/handlers/trait.py#L152-L178