Repository navigation
Fix TestCreateTempURL flaky test by removing hardcoded port dependency - #3662
Merged
Merged
Conversation
SetupPersistentPortHTTP used t.Errorf on bind failure, which didn't stop execution and caused a nil pointer panic on server.Start(). Changed to t.Fatalf to fail cleanly. Replaced SetupPersistentPortHTTP with SetupHTTP in objectstorage temp URL tests since the HMAC signature only covers the path, not the host:port. This eliminates the flaky port-already-in-use failures in CI. Fixes gophercloud#3661.
… tests Several tests used t.Errorf after fallible operations, which logs the error but doesn't stop execution. This caused nil pointer dereferences when subsequent code accessed the result. Replace with th.AssertNoErr which calls t.Fatal internally, stopping the test immediately on error.
github-actions
Bot
added
edit:objectstorage
stephenfin
approved these changes
Mar 26, 2026
stephenfin
left a comment
stephenfin
left a comment
Contributor
There was a problem hiding this comment.
I guess #3398 didn't do enough
|
Failed to backport PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetupPersistentPortHTTP used t.Errorf on bind failure, which didn't stop
execution and caused a nil pointer panic on server.Start(). Changed to
t.Fatalf to fail cleanly.
Replaced SetupPersistentPortHTTP with SetupHTTP in objectstorage temp URL
tests since the HMAC signature only covers the path, not the host:port.
This eliminates the flaky port-already-in-use failures in CI.
Fixes #3661.