Repository navigation
Implement CREATE/UPDATE operation on Placement traits - #3668
Conversation
c883236 to
3d497ec
Compare
Related: gophercloud#526 API reference: https://docs.openstack.org/api-ref/placement/#traits Code reference: https://github.com/openstack/placement/blob/stable/2025.1/placement/handlers/trait.py#L67-L103 Signed-off-by: Dominik Danelski <[email protected]>
3d497ec to
9400749
Compare
|
It looks like we're also getting a 502 for one of the test while we're expecting a 204: |
Co-authored-by: Martin André <[email protected]>
It's useless, as API doesn't take any arguments at the moment. That's unlikely to change in the near future. Signed-off-by: Dominik Danelski <[email protected]>
|
That test seemed like a fluke not directly related to the implemented functionality. It didn't occur to me on my infrastructure and here the status changed after recheck on committing a change to some comment. |
The same test, failed in the DELETE PR as well, also against epoxy. I see you rebase and it re-run the tests and this time it worked, but perhaps it would be good to investigate if there's not something weird going on, if we can pin point what the exact issue was. |
mandre
left a comment
There was a problem hiding this comment.
Let's keep an eye on the placement periodic job, see if we have not introduced a flaky test.
|
Failed to backport PR to |
Related: #526
API reference: https://docs.openstack.org/api-ref/placement/#traits
Code reference:
https://github.com/openstack/placement/blob/stable/2025.1/placement/handlers/trait.py#L67-L103