Skip to content

Implement CREATE/UPDATE operation on Placement traits - #3668

Merged
mandre merged 3 commits into
gophercloud:mainfrom
Etua:add-trait-create-operation
Mar 31, 2026
Merged

mandre merged 3 commits into
gophercloud:mainfrom
Etua:add-trait-create-operation

Conversation

@Etua

@Etua Etua commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the edit:placement This PR updates placement code label Mar 26, 2026
@Etua Etua changed the title [Pending #3658] Add trait create operation [Pending #3658] Implement CREATE/UPDATE operation on Placement traits Mar 27, 2026
@Etua
Etua force-pushed the add-trait-create-operation branch from c883236 to 3d497ec Compare March 27, 2026 12:16
@Etua Etua changed the title [Pending #3658] Implement CREATE/UPDATE operation on Placement traits Implement CREATE/UPDATE operation on Placement traits Mar 27, 2026
@Etua
Etua force-pushed the add-trait-create-operation branch from 3d497ec to 9400749 Compare March 27, 2026 15:20
@github-actions github-actions Bot added semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Mar 27, 2026
@coveralls

coveralls commented Mar 27, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 63.898% (+63.9%) from 0.0%
when pulling 5c4a59a on Etua:add-trait-create-operation
into 8dfa2dc on gophercloud:main.

Comment thread openstack/placement/v1/traits/doc.go Outdated
Comment thread openstack/placement/v1/traits/requests.go Outdated
@mandre

mandre commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

It looks like we're also getting a 502 for one of the test while we're expecting a 204:

"Expected HTTP response code [201 204] when accessing [PUT http://10.1.1.115/placement/traits/CUSTOM_WY5WWFUO], but got 502 instead: <!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>502 Bad Gateway</title>\n</head><body>\n<h1>Bad Gateway</h1>\n<p>The proxy server received an invalid\r\nresponse from an upstream server.<br />\r\n</p>\n<p>Additionally, a 204 No Content\nerror was encountered while trying to use an ErrorDocument to handle the request.</p>\n<hr>\n<address>Apache/2.4.58 (Ubuntu) Server at 10.1.1.115 Port 80</address>\n</body></html>"

https://github.com/gophercloud/gophercloud/actions/runs/23653607837/job/68904732561?pr=3668#step:7:1234

Etua and others added 2 commits March 30, 2026 12:58
It's useless, as API doesn't take any arguments at the moment. That's
unlikely to change in the near future.

Signed-off-by: Dominik Danelski <[email protected]>
@Etua

Etua commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

That test seemed like a fluke not directly related to the implemented functionality. It didn't occur to me on my infrastructure and here the status changed after recheck on committing a change to some comment.

@mandre

mandre commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

That test seemed like a fluke not directly related to the implemented functionality. It didn't occur to me on my infrastructure and here the status changed after recheck on committing a change to some comment.

The same test, failed in the DELETE PR as well, also against epoxy. I see you rebase and it re-run the tests and this time it worked, but perhaps it would be good to investigate if there's not something weird going on, if we can pin point what the exact issue was.

@mandre mandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep an eye on the placement periodic job, see if we have not introduced a flaky test.

@mandre
mandre added this pull request to the merge queue Mar 31, 2026
Merged via the queue into gophercloud:main with commit 2e5f357 Mar 31, 2026
63 checks passed
@github-actions

Copy link
Copy Markdown

Failed to backport PR to v2 branch. See logs for details.

@Etua
Etua deleted the add-trait-create-operation branch March 31, 2026 09:33
@mandre mandre added backport-v2 This PR will be backported to v2 and removed backport-v2 This PR will be backported to v2 labels Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:placement This PR updates placement code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants