Skip to content

Implement resource classes DELETE operation - #3677

Merged
mandre merged 1 commit into
gophercloud:mainfrom
Etua:implement-resource-classes-delete-operation
Apr 2, 2026
Merged

mandre merged 1 commit into
gophercloud:mainfrom
Etua:implement-resource-classes-delete-operation

Conversation

@github-actions github-actions Bot added edit:placement This PR updates placement code semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Mar 31, 2026
@coveralls

coveralls commented Mar 31, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 63.953% (+0.01%) from 63.943%
when pulling 0345eac on Etua:implement-resource-classes-delete-operation
into 0276a08 on gophercloud:main.

@mandre

mandre commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Actually, if you already have the full implementation of the API endpoint ready, it might be better to submit it in one PR rather than one individual PR per API call, so it's easier to backport. The guidelines predate the creation of stable branches, so it might be worth revisiting.

@Etua

Etua commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

All right. I can do it with the new ones.

@Etua Etua changed the title [Pending #3676] Implement resource classes delete operation [Pending #3676] Implement resource classes DELETE operation Apr 2, 2026
@Etua

Etua commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

@mandre #3680 is a combined one. Do you want me to merge this one with #3676 in a similar way? I didn't do it since you've already merged #3675.

@mandre

mandre commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

@mandre #3680 is a combined one. Do you want me to merge this one with #3676 in a similar way? I didn't do it since you've already merged #3675.

Let's keep the PRs for resource classes separate. Thank you for updating #3680.

@Etua
Etua force-pushed the implement-resource-classes-delete-operation branch from 6826170 to 0345eac Compare April 2, 2026 13:29
@Etua Etua changed the title [Pending #3676] Implement resource classes DELETE operation Implement resource classes DELETE operation Apr 2, 2026
@mandre
mandre enabled auto-merge April 2, 2026 13:40
@mandre
mandre added this pull request to the merge queue Apr 2, 2026
Merged via the queue into gophercloud:main with commit bdd3eae Apr 2, 2026
63 checks passed
@Etua
Etua deleted the implement-resource-classes-delete-operation branch April 2, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:placement This PR updates placement code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants