Repository navigation
Implement resource provider aggregates - #3685
Conversation
Related: gophercloud#526 API reference: https://docs.openstack.org/api-ref/placement/#list-resource-provider-aggregates Code reference: https://opendev.org/openstack/placement/src/branch/stable/2026.1/placement/handlers/aggregate.py#L81-L99 Signed-off-by: Dominik Danelski <[email protected]>
Related: gophercloud#526 API reference: https://docs.openstack.org/api-ref/placement/#update-resource-provider-aggregates Code reference: https://opendev.org/openstack/placement/src/branch/stable/2026.1/placement/handlers/aggregate.py#L102-L132 Signed-off-by: Dominik Danelski <[email protected]>
github-actions
Bot
added
edit:placement
|
coverage: 64.002% (+0.03%) from 63.973% — Etua:implement-resource-provider-aggregates into gophercloud:main |
|
@mandre Seems like the test failed on one branch due to setup issues. |
re-running it now, let's see how it goes. |
|
@mandre Looks like it passed on recheck. |
We don't provide resource provider's generation in request nor do we get it back in response. The original tests got it slightly wrong; fix it. Automatically correct the request if user wrongly provides generation in opts for pre-1.19. Signed-off-by: Dominik Danelski <[email protected]>
|
@mandre I acknowledged the difference between 1.19+ and earlier versions, but I got it wrong due to a subtlety: the request and its response are identical only for 1.19+, yet I acted as if it was also true for 1.10-1.18. Even though the tests passed, the values checked were wrong. I created the comment highlighting the difference, lest someone miss it like I did. |
|
Failed to backport PR to |
3 participants
Related: #526
API reference:
https://docs.openstack.org/api-ref/placement/#update-resource-provider-aggregates
https://docs.openstack.org/api-ref/placement/#list-resource-provider-aggregates
Code reference:
https://opendev.org/openstack/placement/src/branch/stable/2026.1/placement/handlers/aggregate.py#L102-L132
https://opendev.org/openstack/placement/src/branch/stable/2026.1/placement/handlers/aggregate.py#L81-L99