Repository navigation
Add support for listing recordsets across all zones - #3688
Conversation
github-actions
Bot
added
edit:dns
|
coverage: 64.021% (+0.008%) from 64.013% — Sharpz7:dns-recordsets-list-all into gophercloud:main |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
Thanks! The code looks good (apart from the misplaced listAllRecordSetsURL() function) but I would really like tests before we merge it. It should be relatively easy to add both unit tests and acceptance tests.
|
Thanks @mandre . Happy to do all of that |
|
@mandre I think that is it ready to go |
Sorry I missed the ping. I'll take a look today. |
|
Would you be able to squash your changes before we merge? |
|
@mandre are you not able to squash on the merge side - just for your reference? Regardless, I'll do it today. Thank you :)) |
Apparently not anymore since we enabled merge queue. This is what the github UI looks like now: 
I might have been able to push to your branch directly, I'm going to give it a try. |
This change introduces a new ListAll function and helper URL builder to expose the Designate /recordsets endpoint via gophercloud. This allows callers to retrieve recordsets across all zones, in addition to the existing per-zone ListByZone helper. The new ListAll function: - Reuses the existing ListOpts/ListOptsBuilder types for filtering, sorting, and pagination. - Returns a pagination.Pager consistent with other list operations in this package.
803b93a to
ef1e621
Compare
we can enable squash |
|
@mandre apologizes I had meetings and was just about to do the squash now! I appreciate your time greatly. |
4 participants
This change introduces a new ListAll function and helper URL builder to expose the Designate /recordsets endpoint via gophercloud. This allows callers to retrieve recordsets across all zones, in addition to the existing per-zone ListByZone helper.
The new ListAll function:
Fixes #3687
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
TODO