Repository navigation
Address review comments from resourceprovider aggregates PR - #3711
Merged
Merged
Conversation
stephenfin
force-pushed
the
placement-aggregates-fixups
branch
from
April 10, 2026 12:45
4cbdc3a to
6d0b370
Compare
github-actions
Bot
added
semver:patch
Per comments [1], remove an unnecessary helper and tweak some tests. [1] gophercloud#3709 Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
placement-aggregates-fixups
branch
from
April 10, 2026 13:08
6d0b370 to
88702e7
Compare
|
coverage: 64.022% (-0.008%) from 64.03% — shiftstack:placement-aggregates-fixups into gophercloud:main |
mandre
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per comments on #3709, remove an unnecessary helper and tweak some tests.