Repository navigation
fix: skip non-struct fields in extractIntoPtr slice path to prevent unmarshal panic - #3726
Merged
Merged
Conversation
mandre
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In extractIntoPtr function (link), the slice path iterates over all fields of the target struct and attempts to unmarshal the full JSON body into each one. When the target struct contains a non-struct field, such as a *bool (as described below), the code attempts to unmarshal a JSON object into it, causing a type mismatch error.
This PR proposes a fix to only decode embedded structs in the loop, adding a check that skips non-struct types. All other field types are handled correctly by this
ExtractIntocall and by the final json.Unmarshal call after the loop.