Repository navigation
db/instances: remove hardcoded 300GB size cap - #3734
Merged
mandre merged 2 commits intoMay 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hi @DDuckSCH21, thanks for proposing a PR for this fix. Could you please add acceptance tests for this change?
Also, would you mind fixing the link to the issue in the PR description?
github-actions
Bot
added
semver:patch
|
coverage: 64.028% (+0.02%) from 64.013% — DDuckSCH21:fix/db-instance-size-upper-limit into gophercloud:main |
mandre
reviewed
May 7, 2026
Co-authored-by: Martin André <[email protected]>
mandre
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded upper limit (300 GB) from
instances.CreateOpts.Sizeclient-side validation in
openstack/db/v1/instances.Current behavior rejects
Size > 300before request is sent.New behavior validates only
Size >= 1and leaves deployment-specific maximumvalidation to the OpenStack/Trove API.
Tests added:
Size: 301inToInstanceCreateMap()Size: 0inToInstanceCreateMap()Fixes #3733