Repository navigation
Add Placement resourceprovider list post 1.39 - #3757
Merged
mandre merged 1 commit intoMay 27, 2026
Merged
Conversation
Etua
force-pushed
the
add-post-139-placement-resource-provider-list
branch
from
May 18, 2026 09:49
bc1a1bc to
1103515
Compare
Etua
force-pushed
the
add-post-139-placement-resource-provider-list
branch
from
May 18, 2026 10:22
1103515 to
030a95b
Compare
Allows for repeating required and member_of arguments. Change of the type of field, microversions.go required. Related gophercloud#526 Signed-off-by: Dominik Danelski <[email protected]>
Etua
force-pushed
the
add-post-139-placement-resource-provider-list
branch
from
May 18, 2026 10:56
030a95b to
740255e
Compare
Contributor
Author
|
@mandre By the way, could you take a look at this one? It's pretty straightforward and doesn't change the existing behaviour. It silently fixes a bad choice (IMO) in the tests, but that change is easy to review too. |
mandre
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for repeating required and member_of arguments. Change of the type of field, microversions.go required.
Related #526