Repository navigation
CI: improve test assertions - #3777
Merged
Merged
Conversation
All equality assertion helpers (AssertEquals, CheckEquals, AssertDeepEquals, CheckDeepEquals, etc.) expect (t, expected, actual) but many call sites had the arguments swapped, putting the actual value first and the expected literal second. This causes confusing error messages on test failure.
Fix bugs where assertions compared the wrong field or compared a value to itself, silently passing due to empty string values.
github-actions
Bot
added
edit:networking
|
coverage: 63.519% (-0.5%) from 63.981% — shiftstack:test-assertions into gophercloud:main |
github-actions
Bot
added
semver:patch
stephenfin
reviewed
May 28, 2026
stephenfin
left a comment
stephenfin
left a comment
Contributor
There was a problem hiding this comment.
Looks like this still needs some work, but I have a suggestion inline. We can do that later also, given this is already quite large
github-actions
Bot
added
edit:placement
Add AssertTrue, AssertFalse, CheckTrue, CheckFalse for boolean assertions, and AssertEqualsIgnoreCase, CheckEqualsIgnoreCase for case-insensitive string comparisons. Replace all existing uses of AssertEquals and CheckEquals with boolean literal arguments to use the new helpers instead.
Assert all fields that are set during Create and Update operations across all acceptance tests. This ensures that returned objects contain the expected values and helps catch field-mapping bugs.
stephenfin
approved these changes
Jun 5, 2026
|
Failed to backport PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things: