Repository navigation
Add Ironic vendor passthru helpers - #3785
Merged
Merged
Conversation
Contributor
Author
|
This PR was created with assistance from OpenAI Codex. Maintainers are free to close this PR with no explanation. |
github-actions
Bot
added
edit:baremetal
|
coverage: 64.034% (+0.05%) from 63.981% — Sharpz7:ironic-vendor-passthru into gophercloud:main |
Sharpz7
marked this pull request as ready for review
June 2, 2026 16:57
Sharpz7
changed the title
Contributor
|
Hey @Sharpz7 just to let you know we have nothing against your PRs or the use of AI for helping you generating them. We're just very busy with other stuff, and we'll get to them eventually. Thanks for your patience. |
Contributor
Author
|
All good @mandre , appreciate you getting in touch. |
stephenfin
approved these changes
Aug 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds generic Ironic vendor passthru support for both node and driver endpoints:
This was created with assistance from OpenAI Codex.
Closes part of #1429.
Testing
env GOCACHE=/tmp/go-build GOMODCACHE=/tmp/go-mod go test ./openstack/baremetal/v1/nodes/testing ./openstack/baremetal/v1/drivers/testingenv GOCACHE=/tmp/go-build GOMODCACHE=/tmp/go-mod go test -tags 'acceptance baremetal nodes drivers' ./internal/acceptance/openstack/baremetal/v1 -run TestNonexistent -count=0