Repository navigation
dns: add AllProjects support to zones.List via X-Auth-All-Projects header - #3801
Merged
kayrus merged 1 commit intoJun 18, 2026
Merged
Conversation
kayrus
reviewed
Jun 17, 2026
github-actions
Bot
added
semver:minor
|
coverage: 63.545% (+0.03%) from 63.519% — abhijith-darshan:feat/dns-zones-all-projects-header into gophercloud:main |
kayrus
reviewed
Jun 17, 2026
Contributor
|
All good, but could you also add functional tests running under admin account (see |
Add ListOptsHeadersBuilder optional interface and AllProjects/SudoTenantID fields to ListOpts, allowing admin users to enumerate zones across all projects via X-Auth-All-Projects header, and to impersonate a tenant via X-Auth-Sudo-Tenant-ID header. List() uses a type assertion to remain backward compatible with existing ListOptsBuilder implementations. Functional tests require admin credentials via clients.RequireAdmin. Signed-off-by: abhijith-darshan <[email protected]>
kayrus
approved these changes
Jun 18, 2026
kayrus
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3800
Links to the line numbers/files in the OpenStack source code that support the code in this PR:
https://opendev.org/openstack/designate/src/commit/12a5256eb51a22acc414fe7082f857355c736d5a/designate/api/middleware.py#L62-L72