Repository navigation
baremetal: add vendor/model/serial_number to FirmwareComponent - #3849
Conversation
|
Hey @karampok, sorry for the delay. Per the api-ref[1] and the source code[2], we currently don't have those fields available. I saw there is a patch in gerrit in progress[3]. I would say that we can't merge this until this land the upstream code. Please ping us when you think it is ready for review. [1] https://docs.openstack.org/api-ref/baremetal/#node-firmware-nodes |
|
Sounds good, I made the PR draft until then. Thanks for the comment |
|
hi @winiciusallan this https://review.opendev.org/c/openstack/ironic/+/992034 has been merged. Not sure the 1, 2 will be updated automatically i need to check. But we can start looking if the PR is ok or missing something. Thanks |
|
@karampok looks like github actions had some degradation early today. would you mind rebasing and pushing it again so we can trigger the jobs? |
Prepares gophercloud for Ironic microversion 1.114 which adds hardware
identity fields to GET /v1/nodes/{ident}/firmware (spec:
https://review.opendev.org/c/openstack/ironic-specs/+/985800).
Operators currently cannot correlate a firmware record with inventory
entries. Ironic will populate vendor/model/serial_number from Redfish
resources already fetched during firmware caching -- no extra BMC calls.
Fields use pointer types (*string) per gophercloud convention: nil when
the API does not return them (microversion < 1.114), non-nil otherwise.
Assisted-By: Claude <[email protected]>
5438daa to
72cdeba
Compare
github-actions
Bot
added
semver:minor
|
coverage: 63.562%. remained the same — karampok:feat/firmware-component-fields into gophercloud:main |
winiciusallan
left a comment
winiciusallan
left a comment
There was a problem hiding this comment.
Looks good, thanks! Unfortunately, we do not use Redfish in our acceptance tests, so we can't reliably test your changes against an operational OpenStack deployment.
Maybe it'd be good to have it in near future.
|
Hi thanks for looking
I am not sure what you mean, that the PR cannot be merged any time soon or? Context: I need this for metal3-io/baremetal-operator#3424 which uses the project as dependency and I suppose. Thanks! |
yes, it can! just taking notes because we need to improve our CI to cover more cases and reliably test and merge thank you for your contribution! |
4 participants
Summary
Vendor,Model,SerialNumberpointer fields toFirmwareComponentstructGET /v1/nodes/{ident}/firmware*stringper gophercloud convention: nil when API does not return them (microversion < 1.114)Reference
Test plan
Assisted-By: Claude [email protected]