Repository navigation
Add methods for Manila share type get and update - #3853
Merged
Merged
Conversation
Share types are a mechanism for supporting multi-tenant access to a common file storage service. This commit defines share type get and update operations, enabling callers to control the management of Manila share types. Signed-off-by: Stig Telfer <[email protected]>
github-actions
Bot
added
the
edit:sharedfilesystems
kayrus
reviewed
Jul 14, 2026
winiciusallan
left a comment
winiciusallan
left a comment
Contributor
There was a problem hiding this comment.
Hey @TBExtent, would you mind adding some acceptance tests?
Contributor
Author
|
Working on some, having fun with microversions |
github-actions
Bot
added
semver:minor
|
coverage: 63.567% (+0.02%) from 63.545% — stackhpc:manila-sharetype-getset into gophercloud:main |
winiciusallan
left a comment
winiciusallan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the tests, @TBExtent. Dropped a few comments inline.
kayrus
reviewed
Jul 17, 2026
github-actions
Bot
added
semver:major
kayrus
approved these changes
Jul 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2026
Contributor
Author
|
Hi @kayrus, it failed to merge due to an internal error in Coveralls, please could you add it to the merge queue again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3842
Implement Manila share type get and update API methods.
API reference for share types: https://docs.openstack.org/api-ref/shared-file-system/#share-types
Unit tests:
Adds unit tests for getting and updating sharetypes