Repository navigation
core: validation for missing response keys in extractIntoPtr - #3897
Merged
Merged
Conversation
This prevents silent failures when an empty or invalid resource ID causes a wrong API endpoint to be called. The fix detects when the expected response key is missing but other data exists in the response, returning a clear error instead of allowing nil values to propagate. The validation allows empty responses (for APIs like tokens where data is in headers) while catching all cases where the wrong endpoint was called due to invalid parameters.
github-actions
Bot
added
edit:gophercloud
IlanZuckerman
approved these changes
Jul 30, 2026
IlanZuckerman
left a comment
IlanZuckerman
left a comment
Contributor
There was a problem hiding this comment.
LGTM. One proposal for the error message though.
stephenfin
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents silent failures when an empty or invalid resource ID causes a wrong API endpoint to be called. The fix detects when the expected response key is missing but other data exists in the response, returning a clear error instead of allowing nil values to propagate.
The validation allows empty responses (for APIs like tokens where data is in headers) while catching all cases where the wrong endpoint was called due to invalid parameters.
Fixes: kubernetes/cloud-provider-openstack#3101