Skip to content

feat: add loadbalancer provider capabilities - #3932

Merged
winiciusallan merged 1 commit into
gophercloud:mainfrom
jihyun-huh:feat/provider-capabilities
Sep 2, 2026
Merged

winiciusallan merged 1 commit into
gophercloud:mainfrom
jihyun-huh:feat/provider-capabilities

Conversation

@jihyun-huh

Copy link
Copy Markdown
Contributor

Fixes #3931

This PR is to support for listing flavor and availability zone capabilities in a provider specific way.

  • add ListFlavorCapabilities
  • add ListAvailabilityZoneCapabilities
  • add unit and acceptance tests
  • update doc.go

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

the requested codes are references here:

@github-actions github-actions Bot added edit:loadbalancer This PR updates loadbalancer code semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Aug 10, 2026
@coveralls

coveralls commented Aug 10, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 63.613% (+0.03%) from 63.58% — jihyun-huh:feat/provider-capabilities into gophercloud:main

@jihyun-huh jihyun-huh changed the title loadbalancer: add provider capabilities feat: add loadbalancer provider capabilities Aug 10, 2026

@winiciusallan winiciusallan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, thanks for adding these calls @jihyun-huh! I left one question about something that I personally would like to see in the acceptance tests.

Comment thread internal/acceptance/openstack/loadbalancer/v2/providers_test.go
@jihyun-huh
jihyun-huh force-pushed the feat/provider-capabilities branch from 465829d to 493fa98 Compare August 18, 2026 10:06

@IlanZuckerman IlanZuckerman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for few minor comments (for your consideration).

Comment thread internal/acceptance/openstack/loadbalancer/v2/providers_test.go Outdated
Comment thread internal/acceptance/openstack/loadbalancer/v2/providers_test.go Outdated
Comment thread internal/acceptance/openstack/loadbalancer/v2/providers_test.go Outdated
@jihyun-huh
jihyun-huh force-pushed the feat/provider-capabilities branch from 493fa98 to 43d920a Compare August 24, 2026 14:43
@winiciusallan
winiciusallan added this pull request to the merge queue Sep 2, 2026
Merged via the queue into gophercloud:main with commit 2839b4f Sep 2, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:loadbalancer This PR updates loadbalancer code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loadbalancer: add support for provider flavor and availability zone capabilities

5 participants