Repository navigation
Add migrations list support in compute service - #3951
Merged
Merged
Conversation
github-actions
Bot
added
semver:minor
stephenfin
requested changes
Aug 17, 2026
stephenfin
left a comment
stephenfin
left a comment
Contributor
There was a problem hiding this comment.
Looks like there are a few changes needed here. You can run make lint to catch much of these locally. I have a few other captalisation-related things I'd like to see tweaked also.
tobias-urdin
force-pushed
the
osmigrations
branch
from
August 17, 2026 11:44
6ad3485 to
454e45a
Compare
Contributor
Author
Thanks! I've updated based on suggestions and checked testing. Let's see how it goes. |
stephenfin
previously approved these changes
Aug 17, 2026
Contributor
|
Assuming CI is happy, I'm good with this. |
stephenfin
enabled auto-merge
August 17, 2026 17:02
stephenfin
disabled auto-merge
August 17, 2026 22:48
|
coverage: 63.559% (-0.003%) from 63.562% — tobias-urdin:osmigrations into gophercloud:main |
This adds migration list support for the compute service based on the previous PR gophercloud#3244 Fixes: gophercloud#3243 Co-Authored-By: avsmirnov <[email protected]> Signed-off-by: Tobias Urdin <[email protected]>
tobias-urdin
force-pushed
the
osmigrations
branch
from
August 18, 2026 06:53
454e45a to
164dea1
Compare
Contributor
Author
|
Another round of lint fixes. |
stephenfin
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds migration list support for the compute
service based on the previous PR #3244
Fixes: #3243