Repository navigation
pagination: Return error on missing resource key - #3975
Merged
Merged
Conversation
This doesn't appear to have ever been used. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
keyed-pages-extra
branch
from
August 20, 2026 13:06
638c1a8 to
ed22afa
Compare
github-actions
Bot
added
the
edit:gophercloud
This is better than silently failing. Signed-off-by: Stephen Finucane <[email protected]> Assisted-By: Claude Opus 4.6 <[email protected]>
stephenfin
force-pushed
the
keyed-pages-extra
branch
from
August 20, 2026 13:10
ed22afa to
e0ba184
Compare
github-actions
Bot
added
semver:minor
|
coverage: 63.585% (+0.004%) from 63.581% — shiftstack:keyed-pages-extra into gophercloud:main |
mandre
approved these changes
Aug 20, 2026
mandre
left a comment
mandre
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks for the quick fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #3947 that returns an error if the requested key was not found on a page, rather than silently ignoring the key.