Repository navigation
reservation: add hosts resources - #3998
Merged
Merged
Conversation
github-actions
Bot
added
edit:reservation
|
coverage: 63.603% (+0.05%) from 63.552% — barnes-c:reservation-hosts into gophercloud:main |
barnes-c
marked this pull request as draft
August 31, 2026 15:53
barnes-c
force-pushed
the
reservation-hosts
branch
from
August 31, 2026 15:54
f058610 to
45cee7e
Compare
15 of 19 tasks
barnes-c
changed the title
This commit adds the hosts package with the GET /os-hosts endpoint Signed-off-by: Christopher Barnes <[email protected]>
barnes-c
force-pushed
the
reservation-hosts
branch
from
September 6, 2026 17:47
45cee7e to
777f5ff
Compare
github-actions
Bot
added
semver:minor
barnes-c
changed the title
barnes-c
marked this pull request as ready for review
September 6, 2026 17:49
mandre
reviewed
Sep 7, 2026
mandre
left a comment
mandre
left a comment
Contributor
There was a problem hiding this comment.
Seems good, just a concern about possible API breakage, in case the blazar API evolves. I'm actually unsure about this, so looking for your feedback as well.
Also feel free to bundle more API calls in the same PR, for example all of the Host calls: this will be simpler if we want to backport the implementation to v2, and will ensure we have proper acceptance tests before merging anything.
this commits add the stubs for ListOpts Signed-off-by: Christopher Barnes <[email protected]>
This commit adds the GET method Signed-off-by: Christopher Barnes <[email protected]>
Signed-off-by: Christopher Barnes <[email protected]>
Signed-off-by: Christopher Barnes <[email protected]>
Signed-off-by: Christopher Barnes <[email protected]>
Signed-off-by: Christopher Barnes <[email protected]>
…26.2 Signed-off-by: Christopher Barnes <[email protected]>
Signed-off-by: Christopher Barnes <[email protected]>
winiciusallan
approved these changes
Sep 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 14, 2026
Contributor
Author
|
Hi @winiciusallan & @mandre, I think this PR got stuck. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3987
Adds the
hostspackage to the Reservation (Blazar) v1 service client, covering the Hosts suite of the api-ref:ListGET /os-hostsCreatePOST /os-hostsGetGET /os-hosts/{host_id}UpdatePUT /os-hosts/{host_id}DeleteDELETE /os-hosts/{host_id}/v1/os-hosts(v1_0.py#L27)Resthelper (utils.py#L47-L59).