Repository navigation
[v2] baremetal: account for different types of CPU.Frequency - #4011
Merged
Merged
Conversation
Ironic has two full-featured inspection implementations: via IPA (in-band) and via Redfish. Unfortunately, the implementations disagreed on the type of the Frequency field: IPA uses a string, while the Redfish implementation returns a proper number. We'll eventually clean it up on the Ironic side, but existing API versions will have to live with this duality. This patch updates Gophercloud to handle Frequency as a number of convert it to the current string format, while also exposing the actual value. Signed-off-by: Dmitry Tantsur <[email protected]>
github-actions
Bot
added
v2
|
coverage: 64.015% (+0.005%) from 64.01% — bp-v2-0bffcd8 into v2 |
winiciusallan
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #4006
Ironic has two full-featured inspection implementations: via IPA
(in-band) and via Redfish. Unfortunately, the implementations disagreed
on the type of the Frequency field: IPA uses a string, while the Redfish
implementation returns a proper number.
We'll eventually clean it up on the Ironic side, but existing API
versions will have to live with this duality. This patch updates
Gophercloud to handle Frequency as a number of convert it to the current
string format, while also exposing the actual value.
Ref: https://bugs.launchpad.net/ironic/+bug/2166878
Signed-off-by: Dmitry Tantsur [email protected]