Skip to content

fix flate write pool size to work with best compression - #208

Merged
2 commits merged into
gorilla:masterfrom
FZambia:flate_write_pool_fix
Jan 24, 2017
Merged

2 commits merged into
gorilla:masterfrom
FZambia:flate_write_pool_fix

Conversation

@FZambia

@FZambia FZambia commented Jan 24, 2017

Copy link
Copy Markdown
Contributor

Currently SetCompressionLevel panics: index out of range.

@ghost

ghost commented Jan 24, 2017

Copy link
Copy Markdown

Thanks for spotting this. There's also an issue with level -2. It's only supported on Go 1.7 and up.

@FZambia FZambia mentioned this pull request Jan 24, 2017
@FZambia

FZambia commented Jan 24, 2017

Copy link
Copy Markdown
Contributor Author

Maybe just remove this test then? It actually does not check too much

@ghost

ghost commented Jan 24, 2017

Copy link
Copy Markdown

Yes, remove the test.

@ghost
ghost merged commit 4e4c8d0 into gorilla:master Jan 24, 2017
@ghost ghost locked and limited conversation to collaborators Feb 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant