Repository navigation
Merged
Conversation
kisielk
reviewed
May 28, 2018
| type netConnDeadlineObserver struct { | ||
| t *testing.T | ||
| c net.Conn | ||
| read, write bool |
Contributor
There was a problem hiding this comment.
My only qualm is these variable names are not descriptive of their purpose, making it a bit confusing to understand how this test works. Maybe rename them to readDeadlineUsed and writeDeadlineUsed ?
Author
|
Please take a look again. |
Contributor
|
Thanks |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking at #384, I didn't see test to confirm handshake read and write are under a deadline.