Change .html to .https.html, add tests for [SecureContext] - #809
Merged
Merged
Conversation
kainino0x
marked this pull request as draft
October 29, 2021 22:41
WPT uses the filname `*.https.html` to determine to run the test over an HTTPS connection. This is now required because WebGPU requires [SecureContext]: gpuweb/gpuweb#1363
kainino0x
force-pushed
the
securecontext
branch
from
October 29, 2021 22:43
cbc127f to
3dab150
Compare
|
Previews, as seen when this build job started (3dab150): |
kainino0x
marked this pull request as ready for review
October 29, 2021 23:36
austinEng
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WPT uses the filename
*.https.htmlto determine to run the test over an HTTPS connection. This is now required because WebGPU requires[SecureContext]: gpuweb/gpuweb#1363Also adds tests (one
.htmland one.https.html) that WebGPU is exposed iffglobalThis.isSecureContext.Dry-run results show this change passing on Chromium's CQ:
https://ci.chromium.org/ui/p/chromium/builders/try/dawn-linux-x64-deps-rel/19193/overview
Author checklist for test code/plans:
.unimplemented()on a test./** doc comments */and can be found viahelper_index.txt.Reviewer sign-off for test code/plans: (Note: feel free to pull in other reviewers at any time for any reason.)
(This is critical for coverage. Assume anything without a TODO will be forgotten about forever.)