Suppress error generation in create*PipelineAsync, clarify async steps - #4752
Merged
Merged
Conversation
Captures errors from when `create*PipelineAsync` call into `create*Pipeline`. Also improves the definitions of all device-timeline-async operations: - GPUDevice.createComputePipelineAsync() - GPUDevice.createRenderPipelineAsync() - GPUShaderModule.getCompilationInfo() - GPUQueue.onSubmittedWorkDone() - GPUBuffer.mapAsync() (GPUDevice.popErrorScope() returns a promise, but its device-timeline steps are synchronous.) Improves some language in "Errors & Debugging" and around the device-timeline "device becomes lost" event hooking. Fixes 4714 Fixes 4742
kainino0x
added
the
api resolved
kainino0x
commented
Jul 16, 2024
kainino0x
commented
Jul 16, 2024
Contributor
|
Previews, as seen when this build job started (78bdd0e): |
toji
approved these changes
Jul 16, 2024
This was referenced Jul 18, 2024
Member
|
Thanks for the clarifying comments. Still LGTM, merging. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures errors from when
create*PipelineAsynccall intocreate*Pipeline.Also improves the definitions of all device-timeline-async operations:
(GPUDevice.popErrorScope() returns a promise, but its device-timeline steps are synchronous.)
Improves some language in "Errors & Debugging" and around the device-timeline "device becomes lost" event hooking.
Fixes #4714
Fixes #4742
Fixes #1629