Repository navigation
fix(cypher): support connected-prefix carried-scalar reentry (#1004) - #1005
Merged
Merged
Conversation
lmeyerov
marked this pull request as ready for review
April 1, 2026 02:06
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support the narrow direct-Cypher
MATCH ... WITH ... MATCH ...continuation where theWITHcarries one whole-row alias plus scalar outputs derived from that same alias, even when the prefixMATCHis not a literal single-node seed.Closes #1004.
Scope
This PR intentionally stays narrow:
MATCH (a)-[:R]->(b) WITH b, b.id AS bid MATCH (b)-[:S]->(c) ...#981multi-binding projection family#999multi-stage row-carrier architectureImplementation
MATCHseedValidation
Local:
PYTHONPATH=. pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py->456 passed, 46 skippedPYTHONPATH=. pytest -q graphistry/tests/compute/test_gfql.py -k "reentry"->6 passed, 3 skipped, 41 deselectedruff check graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.py-> pass./bin/typecheck.sh-> passDGX / cuDF:
26.02cuda13targeted run ondgx-sparkgraphistry/tests/compute/gfql/cypher/test_lowering.py::test_string_cypher_executes_with_match_reentry_carried_scalars_from_connected_prefix_shape_on_cudf-> passedBenchmark-facing result
Fresh
origin/masterstill hits#973earlier on officialinteractive-short-2, so this PR by itself does not change current master benchmark status yet.But when this change is combined with the closed connected-multihop PR head (
6b17cf642), the motivating official query moves past the oldsingle-node prefix MATCH seedblocker and reaches the next boundary:Cypher MATCH after WITH currently supports a single trailing MATCH patternSo this lane is still a real benchmark unblocker; it just needs the connected-multihop lane underneath it.