Repository navigation
feat(gfql): native chain rows() bindings table (#880) - #1014
Merged
Merged
Conversation
When a native GFQL chain has named ops (n(name=...), e(name=...)) followed by a bare rows() call, automatically serialize the traversal ops as binding_ops so rows() materializes a multi-alias bindings table instead of a single-table view. This enables patterns like: g.gfql([n(name='a'), e_forward(), n(name='b'), rows()]) to produce alias-prefixed columns (a.id, b.id, a.val, etc.) The implementation reuses _gfql_connected_bindings_row_table from the Cypher path — no new algorithms needed, just wiring in chain.py. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Add tests for: unnamed ops (no injection), explicit source param (no override), empty match (empty result), three-hop chain. Also guard against alias_endpoints override. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Verify that binding_ops injection works when the first node op has no name but later ops do — bindings are still materialized for the named aliases. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
combine_steps() previously silently discarded the second alias's boolean tag when two ops shared the same name. Now raises GFQLValidationError with a clear message identifying the conflicting steps. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Add 8 tests covering: - duplicate edge alias rejection - four-hop chain with all aliases - empty first-node match → empty bindings - mid-chain empty edge match → empty bindings - select() with edge alias property projection (r.weight) - select() with missing column raises GFQLTypeError - reverse edge direction bindings Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rows()after named traversal ops to reuse connectedbinding_opsrow materializationrows(binding_ops=...)executionTesting
Notes
select()on a missing alias-prefixed bindings column still raises the existing generic parser error and remains follow-up workrows(binding_ops=...)path, which previously allowed duplicate aliases and produced corrupted duplicate-prefixed columns