Repository navigation
feat(cypher): support comma-separated node-only MATCH - #1019
Merged
Merged
Conversation
lmeyerov
marked this pull request as ready for review
April 2, 2026 03:08
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #990 by supporting comma-separated node-only Cypher
MATCHcartesian products in the local compiler.Closes #990
Prerequisite for #1010
What changed
MATCHclauses without forcing them through the connected-path stitcherrows(binding_ops=...)for node-only alias setsWITHover those cartesian rowsRETURN n.ts < m.ts AS ltrows(binding_ops=...)exposes alias-backed row columnsTests
WHERE, stagedWITH, and non-simple scalar expressions ingraphistry/tests/compute/gfql/cypher/test_lowering.pyrows(binding_ops=[Node, Node])cartesian row-materialization coverage ingraphistry/tests/test_compute_chain.pyVerification
python3.12 -B -m pytest -q graphistry/tests/test_compute_chain.py -k 'ChainBindingsTable'->36 passed, 32 deselectedpython3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'cartesian_node_only or multi_alias_return or multi_alias_with_stage_still_rejected or cypher_to_gfql_supports_multi_alias_scalar_projection'->19 passed, 544 deselected